Skip to content

feat: add reverseUsingStringBuilder method to reverse a string #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 27, 2025
Merged

feat: add reverseUsingStringBuilder method to reverse a string #6182

merged 6 commits into from
Feb 27, 2025

Conversation

geetoor-maven
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.13%. Comparing base (df6da47) to head (21e8247).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6182      +/-   ##
============================================
+ Coverage     74.11%   74.13%   +0.02%     
- Complexity     5192     5195       +3     
============================================
  Files           663      663              
  Lines         17771    17778       +7     
  Branches       3422     3423       +1     
============================================
+ Hits          13171    13180       +9     
+ Misses         4097     4096       -1     
+ Partials        503      502       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geetoor-maven geetoor-maven marked this pull request as ready for review February 26, 2025 15:35
siriak
siriak requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this in a separate class with an appropritate name

@geetoor-maven
Copy link
Contributor Author

Please put this in a separate class with an appropritate name

Thank you for your feedback! I've moved the method to a separate class with an appropriate name as suggested. Let me know if any further adjustments are needed

siriak
siriak approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) February 27, 2025 10:43
@siriak siriak merged commit 849ab91 into TheAlgorithms:master Feb 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geetoor-maven @codecov-commenter @siriak